Skip to content

[codex] Cleanup old gateway secret versions - #61

Merged
Pigbibi merged 1 commit into
mainfrom
codex/cleanup-secret-versions
May 31, 2026
Merged

[codex] Cleanup old gateway secret versions#61
Pigbibi merged 1 commit into
mainfrom
codex/cleanup-secret-versions

Conversation

@Pigbibi

@Pigbibi Pigbibi commented May 31, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • destroy older Secret Manager versions after manually syncing gateway secrets from GitHub
  • keep only the latest active version per synced secret to avoid version-count cost drift

Validation

  • exercised the embedded Python selection logic with a sample payload
  • git diff --check

@Pigbibi
Pigbibi marked this pull request as ready for review May 31, 2026 09:01
@Pigbibi
Pigbibi merged commit edd52b9 into main May 31, 2026
1 check passed
@Pigbibi
Pigbibi deleted the codex/cleanup-secret-versions branch May 31, 2026 09:01

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 13800fe9d5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

--project "${GCP_PROJECT_ID}" \
--format=json \
| python -c 'import json,sys
rows = json.load(sys.stdin)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Indent embedded Python inside the run block

In .github/workflows/main.yml, these newly added Python lines are not indented under the run: | block. Because YAML block scalar content must remain indented, rows = json.load(sys.stdin) terminates the shell script and becomes top-level YAML, so GitHub Actions cannot parse/load this workflow when this file is present.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant